Fix AIIOB in Variable SET changer (#6600)

* Update Variable.java * test + ignore instead of set null --------- Co-authored-by: Moderocky <[email protected]>
SkriptLang · Apr 27, 2024 · d6322ad · d6322ad
1 parent 3e55190
commit d6322ad
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/main/java/ch/njol/skript/lang/Variable.java b/src/main/java/ch/njol/skript/lang/Variable.java
@@ -546,7 +546,10 @@ public void change(Event event, @Nullable Object[] delta, ChangeMode mode) throw
 						}
 						i++;
 					}
-				} else {
+				} else if (delta.length > 0) {
+					// if length = 0, likely a failure in casting
+					// (eg, set vector length of {_notvector} to 1, which casts delta to Vector[], resulting in an empty Vector array)
+					// so just do nothing.
 					set(event, delta[0]);
 				}
 				break;

diff --git a/src/test/skript/tests/regressions/pull-6600-variable-set-changer-aiiob.sk b/src/test/skript/tests/regressions/pull-6600-variable-set-changer-aiiob.sk
@@ -0,0 +1,2 @@
+test "variable set aiiob":
+	set vector length of {_} to 1