Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use asynchronous script reloading #1780

Closed
carlodrift opened this issue Dec 28, 2018 · 8 comments
Closed

Use asynchronous script reloading #1780

carlodrift opened this issue Dec 28, 2018 · 8 comments
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@carlodrift
Copy link

carlodrift commented Dec 28, 2018

No description provided.

@Pikachu920
Copy link
Member

this is already supported though it is still beta. you can turn it on in the config

@TheBentoBox TheBentoBox added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: low Issues that are not harmful to the experience but are related to useful changes or additions. labels Dec 28, 2018
@bensku
Copy link
Member

bensku commented Dec 28, 2018

It's very unstable, though. Not like FAWE - it does not have a risk of corrupting your world - but Skript might crash.

@TheBentoBox
Copy link
Member

TheBentoBox commented Dec 28, 2018

This shouldn't have been closed because this really isn't "already supported". Perhaps there's another issue for it but there are a number of issues with the current implementation:

  1. Unstable af like bensku said. It does seem to work ok for me in basic tests but I really haven't gotten that far into it.
  2. I get log handler errors when reloading any scripts while the server is already running with async loading enabled. This is very likely a skript-mirror issue but it's worth mentioning.
  3. The biggest issue of all: a lot of people control a lot of very important stuff with scripts so we can't afford to have the server actively running while the scripts load -- what we really need is async script RELOADING, not loading, and it should be a separate config option. You'll also note, if you re-read the title, that that's is what this issue is actually asking for. I've tested reloading scripts with async loading enabled and it seems to freeze the server all the same as without it enabled. I can take the +1 minute restart time, it's those regular multi-second hard freezes while the server is active that are the real killer.

@TheBentoBox TheBentoBox reopened this Dec 28, 2018
@bensku
Copy link
Member

bensku commented Dec 29, 2018

Reloading should be asynchronous too, unless it got broken relatively recently. However, some tasks need to be done in server thread due to Bukkit.

@ham1255
Copy link

ham1255 commented Dec 31, 2018

how I do turn it on?

@TheBentoBox
Copy link
Member

Put asynchronous script loading: true in your config somewhere. Feel free to test and report back but I wouldn't use it on a live server yet.

@ham1255
Copy link

ham1255 commented Dec 31, 2018

Yeah sure @TheBentoBox

@Matocolotoe
Copy link
Contributor

That would be awesome if it was stable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Development

No branches or pull requests

7 participants