Status of async script loading #3743
Labels
bug
An issue that needs to be fixed. Alternatively, a PR fixing an issue.
completed
The issue has been fully resolved and the change will be in the next Skript update.
enhancement
Feature request, an issue about something that could be improved, or a PR improving something.
priority: medium
Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).
The
asynchronous script loading
config entry seems to be hidden and has to be manually added to the config to make it work. But, trying on a fresh 1.16.5 server with Skript v2.5.3 using only example scripts, it currently gives this error:Few things there:
The "Thread-5" is not meaningful, it should be changed to something like "Skript async script loader" or such.
Events should have correct async calls to super constructor. (Cause of error)
Maybe re-add to the config with a warning in full caps that this may break things.
The loader thread is currently started even when this config option is disabled (or non-existent), and loops
while (true)
forever (it uses queues, which uses LockSupport#park, so it is performance friendly, but an useless thread drains thread stack, still.), so this line should be changed to only start the thread whenisAsync
method returns true: https://github.com/SkriptLang/Skript/blob/master/src/main/java/ch/njol/skript/ScriptLoader.java#L299The text was updated successfully, but these errors were encountered: