Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow returning multiple elements for each source object in PropertyExpression #5521

Closed
1 task done
Fusezion opened this issue Mar 15, 2023 · 2 comments
Closed
1 task done

Allow returning multiple elements for each source object in PropertyExpression #5521

Fusezion opened this issue Mar 15, 2023 · 2 comments
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).

Comments

@Fusezion
Copy link
Contributor

Suggestion

Add support for returning an array within SimplePropertyExpression#convert()

Why?

I've been trying to use SimplePropertyExpression class a bit more, and one of my classes can return an array of multiple itemstacks, however upon attempting I realized the method doesn't support array like all the other methods do

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this suggestion.
@Fusezion Fusezion changed the title SimplePropertyExpression - support returning array in Convert SimplePropertyExpression - returning array in Convert Mar 15, 2023
@TheLimeGlass
Copy link
Collaborator

#5455

@TheLimeGlass TheLimeGlass added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). up for debate When the decision is yet to be debated on the issue in question PR available Issues which have a yet-to-be merged PR resolving it labels Mar 15, 2023
@TheLimeGlass TheLimeGlass mentioned this issue Mar 15, 2023
Merged
@APickledWalrus
Copy link
Member

I do want to mention here for the record that your primary request is not possible due to how SimplePropertyExpressions work. They are actually just Converters, meaning they must return only 1 element per source object (never 1 to many). However, the linked PR will allow you to achieve this behavior using regular PropertyExpression.

@APickledWalrus APickledWalrus changed the title SimplePropertyExpression - returning array in Convert Allow returning multiple elements for each source object in PropertyExpression Mar 15, 2023
@TheLimeGlass TheLimeGlass added completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it up for debate When the decision is yet to be debated on the issue in question labels Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TheLimeGlass @APickledWalrus @Fusezion