Remove final on isSingle PropertyExpression #5455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLimeGlass
added
the
enhancement
TheLimeGlass
changed the title
AyhamAl-Ali
approved these changes
Feb 17, 2023
This comment was marked as resolved.
This comment was marked as resolved.
1 task
Moderocky
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This final in PropertyExpression is a restriction to the API usage. It should not be final. Some classes even in Skript are forced to use SimpleExpression just because of the isSingle method being final.
This does not make sense anymore for properties that return multiples such as, indices of list variable, permissions, armour, lines of a sign, contents of an inventory, etc. The list goes on and on. Property expressions that could be utilizing the PropertyExpression class.
Related issues: #5521