-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fiery Explosion Effect and Condition #2779
The head ref may contain hidden characters: "APickledWalrus-fiery\u200Bexplosive"
Fiery Explosion Effect and Condition #2779
Conversation
Fixed the condition which also fixed the test. |
src/main/java/ch/njol/skript/conditions/CondExplodesWithFire.java
Outdated
Show resolved
Hide resolved
Did you mean to add that commit? |
Yeah, and I think this is ready to be merged. Just waiting for one more approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just 1 small thing I noticed.
src/main/java/ch/njol/skript/conditions/CondExplodesWithFire.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondExplodesWithFire.java
Outdated
Show resolved
Hide resolved
I'm not sure if I really like the syntax for entities in this. |
src/main/java/ch/njol/skript/conditions/CondExplodesWithFire.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondExplodesWithFire.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondExplodesWithFire.java
Outdated
Show resolved
Hide resolved
Forgot to mention, the class names may as well be changed to |
Syntax should be better now 😃 Edit: I always forget to update the test D: |
This is all good to go
Description
Continuing the current theme of explosion-related PR's, this PR adds a new effect and condition. It allows you to set/check if an explosive entity's explosion will be fiery. It also allows you to set this in the ExplosionPrimeEvent. The syntax could maybe be better for the event part, so I'm open to any suggestions.
EDIT: I will fix the test for this soon.Target Minecraft Versions: Any
Requirements: None
Related Issues: None