Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Past event-world and event-location event values #3679

Merged
merged 5 commits into from
Jan 11, 2021
Merged

Past event-world and event-location event values #3679

merged 5 commits into from
Jan 11, 2021

Conversation

Romitou
Copy link
Member

@Romitou Romitou commented Jan 6, 2021 •
edited
Loading

Description

Simple addition of event values in order to retrieve the world a player comes from in the world change event and the past location in a teleportation event.

on player world change:
	broadcast "%past event-world% -> %event-world%"

on teleport:
	broadcast "%past event-location's world% -> %event-location's world%"

image

Target Minecraft Versions: any
Requirements: none
Related Issues: #3641

@Romitou Romitou changed the title Past event-world event value Past event-world and event-location event values Jan 6, 2021
APickledWalrus
APickledWalrus previously approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me :)

This will probably end up targeting 2.6 as I'm not sure if we plan to add any new features to 2.5

@ShaneBeee ShaneBeee changed the base branch from master to dev-2.5 January 11, 2021 20:33
@ShaneBeee ShaneBeee dismissed APickledWalrus’s stale review January 11, 2021 20:33

The base branch was changed.

ShaneBeee
ShaneBeee approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ShaneBeee ShaneBeee added 2.5 enhancement Feature request, an issue about something that could be improved, or a PR improving something. labels Jan 11, 2021
@ShaneBeee ShaneBeee merged commit 7c5d177 into SkriptLang:dev-2.5 Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaneBeee ShaneBeee ShaneBeee approved these changes

@APickledWalrus APickledWalrus APickledWalrus left review comments

Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Romitou @ShaneBeee @APickledWalrus