Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section API #4020

Merged
merged 12 commits into from
Jun 17, 2021
Merged

Section API #4020

merged 12 commits into from
Jun 17, 2021

Conversation

TPGamesNL
Copy link
Member

@TPGamesNL TPGamesNL commented May 23, 2021

Description

Adds a Section API to Skript, to be used internally and by addons.

The conditionals (if, else if and else), loops and while loops have been converted to the new system, but no other sections have been added.


Target Minecraft Versions: any
Requirements: none
Related Issues: #443, #1402 and #1449, #2118, #3680, #4000, #4005 (all non-fixing)

@TPGamesNL TPGamesNL added feature Pull request adding a new feature. 2.6 labels May 23, 2021
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing tooooo bad. Another reviewer is definitely needed to double check ;D

src/main/java/ch/njol/skript/effects/EffContinue.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/lang/util/CodeSection.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/sections/LoopSection.java Outdated Show resolved Hide resolved
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that one question, but it's certainly not going to stop me from approving this! Nice work!

Copy link
Contributor

@Mwexim Mwexim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely changes, something Skript needed for a long time. One issue that will remain is that it will need to wait for #3838 to be merged. After that, the conditions can be implemented smoothly with this new API.

src/main/java/ch/njol/skript/effects/EffContinue.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/lang/util/CodeSection.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/sections/LoopSection.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/sections/WhileSection.java Outdated Show resolved Hide resolved
@TPGamesNL
Copy link
Member Author

Lovely changes, something Skript needed for a long time. One issue that will remain is that it will need to wait for #3838 to be merged. After that, the conditions can be implemented smoothly with this new API.

Thanks. I don't think this PR should wait for #3838.

@Mwexim
Copy link
Contributor

Mwexim commented Jun 10, 2021

Thanks. I don't think this PR should wait for #3838.

I mean it can be implemented later on as well. One of the two PRs will need to adapt to one another then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull request adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants