-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Section API #4020
Section API #4020
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing tooooo bad. Another reviewer is definitely needed to double check ;D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just that one question, but it's certainly not going to stop me from approving this! Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely changes, something Skript needed for a long time. One issue that will remain is that it will need to wait for #3838 to be merged. After that, the conditions can be implemented smoothly with this new API.
I mean it can be implemented later on as well. One of the two PRs will need to adapt to one another then. |
Description
Adds a Section API to Skript, to be used internally and by addons.
The conditionals (if, else if and else), loops and while loops have been converted to the new system, but no other sections have been added.
Target Minecraft Versions: any
Requirements: none
Related Issues: #443, #1402 and #1449, #2118, #3680, #4000, #4005 (all non-fixing)