Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Item cooldown expression + condition #4198

Merged
merged 31 commits into from
Jul 31, 2023

Conversation

AyhamAl-Ali
Copy link
Member

Description

This PR aims to add the ability to check if a specific material of specific players has cooldown or not and adds the ability to get, set and delete/reset that cooldown.


Target Minecraft Versions: 1.12+
Requirements: Minecraft 1.12+
Related Issues: #3986

@APickledWalrus APickledWalrus added the feature Pull request adding a new feature. label Jul 17, 2021
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this one 👍

Just some things to go over:

Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple things

Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should just be these two final things

- Handle IAE for materials
- Handle CCE caused by wrong expression choice
- Change HumanEntity to Player
@Moderocky Moderocky requested review from TPGamesNL and removed request for TPGamesNL April 10, 2023 08:00
@TheLimeGlass TheLimeGlass removed the request for review from TPGamesNL July 31, 2023 07:22
@TheLimeGlass TheLimeGlass merged commit 4d6f42a into SkriptLang:master Jul 31, 2023
4 checks passed
Moderocky pushed a commit to Moderocky/Skript that referenced this pull request Sep 16, 2023
NotSoDelayed pushed a commit to NotSoDelayed/Skript that referenced this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull request adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants