Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1.11.2 sweeping edge #4936

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Fix 1.11.2 sweeping edge #4936

merged 1 commit into from
Jul 21, 2022

Conversation

TheLimeGlass
Copy link
Collaborator

@TheLimeGlass TheLimeGlass commented Jul 21, 2022

Description

Fixed sweeping edge not being registered on 1.11.2 and Skript erroring because it has no allocation to the enchantment.
Sweeping edge actually came out in 1.11.X but it's only registered in 1.12.

Self tested on Java 8 to be working fine.

Note that this is going into dev/2.6 branch


Target Minecraft Versions: 1.11.2
Related Issues: #4933

@TheLimeGlass TheLimeGlass added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. legacy versions Issues or PRs which are only applicable for the server versions 1.9-1.12 2.6 labels Jul 21, 2022
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweeping edge actually came in 1.11.1 I think, but it doesn't matter because we only support the latest revisions of versions

@TheLimeGlass TheLimeGlass changed the title Fix 1.11 sweeping edge Fix 1.11.2 sweeping edge Jul 21, 2022
@AyhamAl-Ali AyhamAl-Ali merged commit f80e047 into dev/2.6 Jul 21, 2022
@TPGamesNL TPGamesNL deleted the fix/1-11-sweeping-edge branch July 22, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. legacy versions Issues or PRs which are only applicable for the server versions 1.9-1.12
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants