Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event naming rule to code conventions #4992

Closed
wants to merge 1 commit into from

Conversation

Pikachu920
Copy link
Member

Description

Adds a naming rule for Event objects to the code conventions. Currently, some contributors use e and others use event. I think we should probably find a standard before this inconsistency continues to grow in the codebase. While my vote would be for using e, I mostly opened this PR as a place to hold the discussion. The actual standard should be whatever most of us agree on.


Target Minecraft Versions: any
Requirements: any
Related Issues: any

@Moderocky
Copy link
Member

I’m always in favour of more rules, but I would vote for event.
For my reasoning you can read my public code standards and style guide.

@AyhamAl-Ali AyhamAl-Ali added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Jul 30, 2022
@Pikachu920
Copy link
Member Author

I’m always in favour of more rules, but I would vote for event. For my reasoning you can read my public code standards and style guide.

yeah now that i think about it, I think event is better. my main rationale for using e was that it is (i think) already the most common name for it in the codebase, but it gets obnoxious when dealing with exceptions.

@SkriptLang SkriptLang locked as off-topic and limited conversation to collaborators Jul 30, 2022
@Pikachu920
Copy link
Member Author

Please discuss in #4993

@TheLimeGlass TheLimeGlass added the up for debate When the decision is yet to be debated on the issue in question label Aug 1, 2022
@TheLimeGlass
Copy link
Collaborator

Closed in favor of more than majority of team agreeing with event

@TheLimeGlass TheLimeGlass deleted the enhancement/naming-rule branch September 13, 2022 22:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. up for debate When the decision is yet to be debated on the issue in question
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants