Re-add support for itemtypes in CondIsOfType

[Mr-Darth]

Description

Looks like #1597 accidentally removed itemtypes support in CondIsOfType. This PR adds it back.

---

Target Minecraft Versions:
Requirements:
Related Issues:

[TheLimeGlass]

There is no entitytype to entitydata converter, this will break past compatability comparing an entity to an entitytype. Why did you remove entitytype?

Not all entitydata match 1:1 with entitytype. EntityData is based off Entity classes, it's designed to be used a literal and return a created entity. Entitytype will be removed in the future as Skript doesn't use Spigot EntityType enum, just not at this current time, so support for it is required.

[Mr-Darth]

There is no entitytype to entitydata converter, this will break past compatability comparing an entity to an entitytype. Why did you remove entitytype?

Not all entitydata match 1:1 with entitytype. EntityData is based off Entity classes, it's designed to be used a literal and return a created entity. Entitytype will be removed in the future as Skript doesn't use Spigot EntityType enum, just not at this current time, so support for it is required.

From the looks of it, entitytype was never meant to be supported (and it isn't, only the pattern accepted it). And EntityType is just EntityData with an amount.

[APickledWalrus]

Might be worth looking into the EntityType thing as Lime mentioned

[TheLimeGlass]

@Mr-Darth

[TheLimeGlass]

#5073 (comment)

[sovdeeth]

Some tests would be nice

[sovdeeth]

Do you still intend to work on this?

Resolved