Fix message sending on legacy versions #5106
Conversation
APickledWalrus
added
bug
| receivers.addAll(world.getPlayers()); | ||
| } | ||
|
|
||
| for (Expression<?> message : getMessages()) { | ||
| if (message instanceof VariableString) { | ||
| BaseComponent[] components = BungeeConverter.convert(((VariableString) message).getMessageComponents(e)); |
There was a problem hiding this comment.
What's the point of BungeeConverter when VariableString also stores the MessageComponents? Can't BungeeConverter just be removed entirely if we're not going to use it.
There was a problem hiding this comment.
MessageComponent is a custom Skript type. BungeeConverter converters our MessageComponent into Spigot/Bungee's component format
There was a problem hiding this comment.
So why was the old code you deleted in this pull request not used again with the BungeeConverter?
There was a problem hiding this comment.
I'm not entirely sure what you mean, but EffBroadcast just hooks into the same behavior as EffMessage now. BungeeConverter is called each time those messages are sent though which probably isn't necessary (it has played-dependent behavior AFAIK)
Description
Title
It looks like players support advanced formatting. I tested on 1.9.4.
This fix is achieved by using the exact same logic as EffMessage.
Target Minecraft Versions: 1.12 and below
Requirements: N/A
Related Issues: