Add lowest solid block #5284
Merged
Add lowest solid block #5284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLimeGlass
approved these changes
Dec 27, 2022
kiip1
suggested changes
Dec 27, 2022
src/main/java/ch/njol/skript/expressions/ExprLowestHighestSolidBlock.java
Outdated
Show resolved
Hide resolved
AyhamAl-Ali
reviewed
Dec 27, 2022
src/main/java/ch/njol/skript/expressions/ExprLowestHighestSolidBlock.java
Outdated
Show resolved
Hide resolved
APickledWalrus
commented
Dec 27, 2022
src/main/java/ch/njol/skript/expressions/ExprLowestHighestSolidBlock.java
Outdated
Show resolved
Hide resolved
TheLimeGlass
requested changes
Dec 28, 2022
kiip1
approved these changes
Mar 12, 2023
TheLimeGlass
previously requested changes
Mar 21, 2023
src/main/java/ch/njol/skript/expressions/ExprLowestHighestSolidBlock.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprLowestHighestSolidBlock.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprLowestHighestSolidBlock.java
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprLowestHighestSolidBlock.java
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprLowestHighestSolidBlock.java
Outdated
Show resolved
Hide resolved
Comment on lines
+12
to
+14
| set block at location(0.5, 0.5, 0.5, "world") to air | ||
| set block at location(0.5, 1.5, 0.5, "world") to air | ||
| set block at location(0.5, 2.5, 0.5, "world") to dirt |
There was a problem hiding this comment.
This will have issues with conflicting with other tests. In the future you'll be able to use event-block after one of my pulls, I forget which one.
Most tests revert the block back to what it was.
This one is problematic because it's near 0,0,0 either new location or I suggest making it restore
There was a problem hiding this comment.
I would imagine that a test should make no expectation regarding the state of the world - so if it is expecting a block to be something at a location, that should be explicitly set at the beginning of the test
There was a problem hiding this comment.
I think that's a good principle to abide by, but setting any blocks you set back to air seems like good defensive behavior in case a test isn't abiding by that.
TheLimeGlass
added
the
breaking changes
|
Syntax isn't old one |
Moderocky
force-pushed
the
master
branch
2 times, most recently
from
bd134d0
to
3f08853
Compare
sovdeeth
approved these changes
Dec 19, 2023
sovdeeth
added
2.9
sovdeeth
added
the
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the lowest solid block and improves the syntax class
Target Minecraft Versions: N/A
Requirements: N/A
Related Issues: