Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ExprPortalCooldown #5356

Merged
merged 16 commits into from
Jul 14, 2023
Merged

Conversation

sovdeeth
Copy link
Member

Description

Adds ExprPortalCooldown and related test.
Any entity's portal cooldown can be read from or written to as a timespan.
Eg: set player's portal cooldown to 5 seconds


Target Minecraft Versions: any
Requirements:
Related Issues: #4185

Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool stuff :)

@AyhamAl-Ali AyhamAl-Ali added the feature Pull request adding a new feature. label Jan 17, 2023
Copy link
Member

@AyhamAl-Ali AyhamAl-Ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR ⚡

@sovdeeth sovdeeth requested review from AyhamAl-Ali and removed request for APickledWalrus January 17, 2023 16:52
Copy link
Member

@Moderocky Moderocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good with lime's changes.

@sovdeeth sovdeeth requested review from UnderscoreTud and removed request for APickledWalrus March 8, 2023 18:57
@TheLimeGlass TheLimeGlass merged commit 5c50a3f into SkriptLang:master Jul 14, 2023
4 checks passed
Moderocky pushed a commit to Moderocky/Skript that referenced this pull request Sep 16, 2023
NotSoDelayed pushed a commit to NotSoDelayed/Skript that referenced this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull request adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants