Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Condition LivingEntity is Jumping #5359

Merged
merged 12 commits into from
Jun 12, 2023
Merged

Condition LivingEntity is Jumping #5359

merged 12 commits into from
Jun 12, 2023

Conversation

NotSoDelayed
Copy link
Contributor

Description

This PR adds condition LivingEntity#isJumping().

Target Minecraft Versions: any
Requirements: none
Related Issues: none

@AyhamAl-Ali AyhamAl-Ali added the feature Pull request adding a new feature. label Jan 18, 2023
@TheLimeGlass
Copy link
Collaborator

TheLimeGlass commented Jan 19, 2023 •
edited
Loading

Skript already has ground state expression and I think condition which uses the Spigot method, so is this method really needed? It's just Paper being Paper having another named method.

@NotSoDelayed
Copy link
Contributor Author

NotSoDelayed commented Jan 26, 2023 •
edited
Loading

Skript already has ground state expression and I think condition which uses the Spigot method, so is this method really needed? It's just Paper being Paper having another named method.

The is on ground condition may not possible to get whether an entity is about to fall or jump, or hovers mid air with levitational effect.

@NotSoDelayed NotSoDelayed requested review from AyhamAl-Ali and UnderscoreTud and removed request for AyhamAl-Ali January 30, 2023 09:44
@NotSoDelayed NotSoDelayed requested review from TheLimeGlass and removed request for UnderscoreTud and AyhamAl-Ali February 4, 2023 14:14
AyhamAl-Ali
AyhamAl-Ali requested changes Feb 14, 2023
View reviewed changes
Copy link
Member

@AyhamAl-Ali AyhamAl-Ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR ⚡

src/main/java/ch/njol/skript/conditions/CondIsJumping.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/conditions/CondIsJumping.java Outdated Show resolved Hide resolved
@NotSoDelayed NotSoDelayed requested review from TheLimeGlass and removed request for UnderscoreTud February 15, 2023 13:56
UnderscoreTud
UnderscoreTud approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@UnderscoreTud UnderscoreTud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@TheLimeGlass TheLimeGlass merged commit 97caf93 into SkriptLang:master Jun 12, 2023
@NotSoDelayed NotSoDelayed deleted the feature/CondIsJumping branch July 8, 2023 16:52
Moderocky pushed a commit to Moderocky/Skript that referenced this pull request Sep 16, 2023
@NotSoDelayed @Moderocky
Condition LivingEntity is Jumping (SkriptLang#5359)
404af10
NotSoDelayed added a commit to NotSoDelayed/Skript that referenced this pull request Oct 30, 2023
@NotSoDelayed
Condition LivingEntity is Jumping (SkriptLang#5359)
cee1189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ankoki Ankoki Ankoki left review comments

@UnderscoreTud UnderscoreTud UnderscoreTud approved these changes

@AyhamAl-Ali AyhamAl-Ali AyhamAl-Ali approved these changes

@TheLimeGlass TheLimeGlass TheLimeGlass approved these changes

Assignees
No one assigned
Labels
feature Pull request adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NotSoDelayed @TheLimeGlass @AyhamAl-Ali @Ankoki @UnderscoreTud