Add support for getting and modifying ItemType inventories #5366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnderscoreTud
added
the
enhancement
TheLimeGlass
requested changes
Feb 4, 2023
Pikachu920
requested review from
TheLimeGlass,
APickledWalrus and
AyhamAl-Ali
TheLimeGlass
approved these changes
Apr 18, 2023
Pikachu920
requested review from
AyhamAl-Ali and
APickledWalrus
and removed request for
AyhamAl-Ali and
APickledWalrus
Moderocky
approved these changes
Jun 28, 2023
|
@Pikachu920 conflicts |
Moderocky
force-pushed
the
master
branch
2 times, most recently
from
bd134d0
to
3f08853
Compare
Moderocky
added
the
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for getting the inventory from an ItemType whose BlockStateMeta implements Container (e.g. shulkers, chests, etc). It also supports modifying the inventory via a proxy which applies any changes to the inventory to the ItemType. The proxy solution is not ideal, but it's the best solution I could find. If you are aware of a better alternative, please let me know!
Target Minecraft Versions: any
Requirements: N/A
Related Issues: kinda sorta #2336