Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add glowing sign text support #5367

Merged
merged 15 commits into from
Dec 19, 2023
Merged

Add glowing sign text support #5367

merged 15 commits into from
Dec 19, 2023

Conversation

Pikachu920
Copy link
Member

Description

Adds a condition and effect for checking and setting the glowing text state of a sign block or item.

Target Minecraft Versions: 1.17+
Requirements: 1.17+
Related Issues: #5361

@Pikachu920 Pikachu920 added the feature Pull request adding a new feature. label Jan 19, 2023
AyhamAl-Ali
AyhamAl-Ali requested changes Jan 19, 2023
View reviewed changes
Copy link
Member

@AyhamAl-Ali AyhamAl-Ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing PR ⚡

src/main/java/ch/njol/skript/conditions/CondGlowingText.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffGlowingText.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffGlowingText.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffGlowingText.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffGlowingText.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffGlowingText.java Outdated Show resolved Hide resolved
src/test/skript/tests/syntaxes/effects/EffGlowingText.sk Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/conditions/CondGlowingText.java Outdated Show resolved Hide resolved
TheLimeGlass
TheLimeGlass requested changes Feb 4, 2023
View reviewed changes
Copy link
Collaborator

@TheLimeGlass TheLimeGlass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A glowing sign item aliases could be added, but that's for the aliases repo.

src/main/java/ch/njol/skript/effects/EffGlowingText.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffGlowingText.java Outdated Show resolved Hide resolved
src/test/skript/tests/syntaxes/effects/EffGlowingText.sk Show resolved Hide resolved
@Pikachu920 Pikachu920 requested review from APickledWalrus and removed request for APickledWalrus February 19, 2023 05:28
@Moderocky Moderocky changed the base branch from master to dev/feature September 18, 2023 10:07
@Moderocky Moderocky added addon-related An issue that is related to an addon and not Skript. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. and removed addon-related An issue that is related to an addon and not Skript. labels Sep 18, 2023
@Moderocky Moderocky requested review from APickledWalrus and removed request for APickledWalrus September 18, 2023 10:15
@Pikachu920 Pikachu920 dismissed APickledWalrus’s stale review December 19, 2023 06:42

review has been addressed

@Pikachu920 Pikachu920 merged commit cc19ac0 into dev/feature Dec 19, 2023
6 checks passed
@Pikachu920 Pikachu920 deleted the feature/glowing-sign-text branch December 19, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UnderscoreTud UnderscoreTud UnderscoreTud approved these changes

@AyhamAl-Ali AyhamAl-Ali AyhamAl-Ali approved these changes

@TheLimeGlass TheLimeGlass TheLimeGlass approved these changes

@APickledWalrus APickledWalrus Awaiting requested review from APickledWalrus

Assignees
No one assigned
Labels
feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Pikachu920 @TheLimeGlass @AyhamAl-Ali @APickledWalrus @UnderscoreTud @Moderocky