Fix two bugs with block iterator #5566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLimeGlass
added
bug
TheLimeGlass
changed the title
AyhamAl-Ali
approved these changes
Mar 30, 2023
TheLimeGlass
changed the title
TheLimeGlass
requested review from
AyhamAl-Ali,
APickledWalrus,
Moderocky and
TPGamesNL
Moderocky
approved these changes
Apr 8, 2023
…x/block-iterator
Sure, there isn't really much to test aside from the block iterator size. The other bug is an exception that's fixed. |
1 task
kiip1
pushed a commit
to mlummh/mlum-skript
that referenced
this pull request
Nov 11, 2023
(cherry picked from commit 8dfa83d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First bug fix is the referenced issue that restricts a vector of zero when grabbing blocks with a single location and single direction.
Bukkit throws an IllegalArgumentException if Vector#isZero is true. So we have to disallow that here.
Second bug is the fact that when using direction with a number, the ExprBlocks expression would not respect the value. So for example
loop blocks 5 above the playerwould loop blocks between the player and 100 blocks above because that was the max target block distance. It now properly loops 5 blocks. No clue how no one ever reported this. I guess i'm the only one that uses Skript's overly complex directional support.I also cleaned up ExprBlocks and BlockLineIterator
Target Minecraft Versions: any
Requirements: none
Related Issues: #5565