-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Expression: Attached Block of Arrow #5589
New Expression: Attached Block of Arrow #5589
Conversation
Is there a reason this isn't a SimplePropertyExpression? |
Then I wouldn't be able to allow usage of |
I don't think that syntax is worth it. Personally, it doesn't even make much grammatical sense to me. Either way, you can still use SimplePropertyExpression but with custom patterns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing from the phone isn't easy but nice PR ⚡️
src/main/java/ch/njol/skript/expressions/ExprAttachedBlock.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprAttachedBlock.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprAttachedBlock.java
Outdated
Show resolved
Hide resolved
@AyhamAl-Ali Discard your requested changes? The expression's base class has been converted to SimplePropertyExpression. Although this kills multi-arrow projectile support in one line. |
Just make the type plural. |
Description
This PR adds a new expression which gets the attached block of arrow(s) to Skript!
Target Minecraft Versions: any
Requirements: -
Related Issues: -