New Expression: Loaded Chunks of World #5662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AyhamAl-Ali
approved these changes
May 1, 2023
TheLimeGlass
requested changes
May 1, 2023
There was a problem hiding this comment.
Should probably be included within https://github.com/SkriptLang/Skript/blob/master/src/main/java/ch/njol/skript/expressions/ExprChunk.java with separate syntax pattern (all of the|all [the]) [loaded] chunks of %worlds% and [the] chunk[s] (of|%-directions%) %locations%
|
Aware that tests are failing. |
|
Fixed cause of test failing and PR ready for review! |
AyhamAl-Ali
approved these changes
May 14, 2023
TheLimeGlass
requested changes
Jun 28, 2023
TheLimeGlass
approved these changes
Jul 11, 2023
Moderocky
requested changes
Jul 12, 2023
Moderocky
approved these changes
Jul 26, 2023
|
This could have a test too, since spawn chunks ought to be loaded in the test environment. |
too many variables |
Moderocky
pushed a commit
to Moderocky/Skript
that referenced
this pull request
Sep 16, 2023
* Initial * Support plural * Merge with ExprChunk * Fix * Fix 2 * Cleanup class to obey code convention * Requested changes * Fix indent * Indent docs and improved pattern --------- Co-authored-by: LimeGlass <[email protected]>
NotSoDelayed
added a commit
to NotSoDelayed/Skript
that referenced
this pull request
Oct 30, 2023
* Initial * Support plural * Merge with ExprChunk * Fix * Fix 2 * Cleanup class to obey code convention * Requested changes * Fix indent * Indent docs and improved pattern --------- Co-authored-by: LimeGlass <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support of getting a list of loaded chunks of a world into Skript!
Target Minecraft Versions: any
Requirements: -
Related Issues: -