Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change uuid default #5676

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Change uuid default #5676

merged 2 commits into from
Mar 21, 2024

Conversation

TheLimeGlass
Copy link
Collaborator

Description

We're going to have to change this default setting at some point. So 2.8 should be the standard. We cannot start changing variables without them being uuid in the first place.


Target Minecraft Versions:
Requirements:
Related Issues: #2987

@TheLimeGlass TheLimeGlass added enhancement Feature request, an issue about something that could be improved, or a PR improving something. 2.8 Targeting a 2.8.X version release labels May 5, 2023
@NotSoDelayed
Copy link
Contributor

Do we need a solution for the aftermath of this change? Existing and future variables which depend on %player% will be desynced due to different index.

@AyhamAl-Ali
Copy link
Member

Breaking change?

@TheLimeGlass TheLimeGlass added the breaking changes Pull or feature requests that contain breaking changes (API, syntax, etc.) label May 6, 2023
@TheLimeGlass
Copy link
Collaborator Author

Do we need a solution for the aftermath of this change? Existing and future variables which depend on %player% will be desynced due to different index.

We literally cannot fix existing variables. How are we supposed to differentiate a player name from a variable name. The only way is to start making it their UUID always.

@Pikachu920
Copy link
Member

okay dont hate me because i totally want this to be the default too, but i'm worried about how breaking this is. can we maybe add some really annoying warnings in 2.8 and then in 2.9 (or even maybe earlier) change the default?

@sovdeeth
Copy link
Member

sovdeeth commented Aug 7, 2023

I'm going to hate you pikachu, but that does sounds sensible.

@Pikachu920
Copy link
Member

I'm going to hate you pikachu, but that does sounds sensible.

image

@Pikachu920
Copy link
Member

alsoooooo if we're technically targeting 2.8 for this, we could make 2.7 the version with said annoying warnings 😉

@AyhamAl-Ali
Copy link
Member

okay dont hate me because i totally want this to be the default too, but i'm worried about how breaking this is. can we maybe add some really annoying warnings in 2.8 and then in 2.9 (or even maybe earlier) change the default?

Could we provide to the user the correct way to migrate manually then? so that no one messes up anything

@Moderocky Moderocky changed the base branch from master to dev/feature September 17, 2023 08:05
@sovdeeth
Copy link
Member

Marked as 2.8 to ensure that we get the warnings into 2.8.

@sovdeeth sovdeeth removed the 2.8 Targeting a 2.8.X version release label Dec 31, 2023
@sovdeeth sovdeeth added feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. 2.9 Targeting a 2.9.X version release labels Mar 19, 2024
@sovdeeth sovdeeth merged commit c6b344c into dev/feature Mar 21, 2024
6 checks passed
@sovdeeth sovdeeth deleted the feature/player-automatic-uuid branch March 21, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.9 Targeting a 2.9.X version release breaking changes Pull or feature requests that contain breaking changes (API, syntax, etc.) enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants