Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Add Item Damge event to ExprDamage #5678

Merged
merged 4 commits into from
Sep 25, 2023
Merged

🚀 Add Item Damge event to ExprDamage #5678

merged 4 commits into from
Sep 25, 2023

Conversation

AyhamAl-Ali
Copy link
Member

@AyhamAl-Ali AyhamAl-Ali commented May 5, 2023 •
edited by APickledWalrus
Loading

Description

In this PR:

  • Added PlayerItemDamageEvent support to ExprDamage
  • Cleaned up the class
  • Fixed RESET change mode being supported in acceptChange but not in change method, since there is no way to get original value of damage the RESET change mode has been removed from accepted change modes
  • Added proper supported events to docs
  • Updated description
  • Updated examples

Target Minecraft Versions: Any
Requirements: None
Related Issues:

@AyhamAl-Ali AyhamAl-Ali added enhancement Feature request, an issue about something that could be improved, or a PR improving something. bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. labels May 5, 2023
sovdeeth
sovdeeth approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth specifying that item damage is supported in the usage error, but it's technically correct as is so I don't think it's a necessary change.

@AyhamAl-Ali
Copy link
Member Author

The meaning in the error message is general indeed, it just holds the meaning of all damage events not just a specific one.

@Moderocky Moderocky changed the base branch from master to dev/feature September 17, 2023 08:03
@Moderocky Moderocky added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Sep 17, 2023
@TheLimeGlass TheLimeGlass merged commit 5941679 into SkriptLang:dev/feature Sep 25, 2023
4 checks passed
@sovdeeth sovdeeth mentioned this pull request Dec 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@Moderocky Moderocky Moderocky approved these changes

@TheLimeGlass TheLimeGlass TheLimeGlass approved these changes

@APickledWalrus APickledWalrus Awaiting requested review from APickledWalrus

@UnderscoreTud UnderscoreTud Awaiting requested review from UnderscoreTud

Assignees
No one assigned
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AyhamAl-Ali @sovdeeth @Moderocky @TheLimeGlass