Fixes error not properly being caught #5798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLimeGlass
added
bug
TheLimeGlass
added
2.7
APickledWalrus
approved these changes
Jul 7, 2023
AyhamAl-Ali
approved these changes
Jul 9, 2023
TheLimeGlass
added a commit
that referenced
this pull request
Jul 9, 2023
Update Utils.java (cherry picked from commit 6caf20c)
TheLimeGlass
added a commit
that referenced
this pull request
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we're using the class loader of a provided plugin, the error if no class being found gets sent through NoClassDefFoundError and not ClassNotFoundException because NoClassDefFoundError refers to the class loader not being able to find the class.
This resulted in Skript critical hard failing, disabling itself and being unresponsive, becoming a pain to task manager end task for the testing environment and addons. Now it errors without crashing itself.