🚀 Add player(nameOrUUID: string, getExactPlayer: boolean) function

[AyhamAl-Ali]

Description

Adds a player function that return player or offlineplayer from name or uuid.

+ player(nameOrUUID, getExactPlayer) :: player # returns none if player is offline
+ offlineplayer(nameOrUUID) :: offlineplayer # returns none only if player does not exist in Minecraft usernames database (not taken)

---

Target Minecraft Versions: Any
Requirements: Any
Related Issues:

• 💡Adding player(name: string) function #5842

[Fusezion]

Was looking over this in the issue the suggested syntax was to do player(nameOrUUID, onlineOnly) is it still planned to make it support online only or was it just weird to see it used? and if not should we do offlinePlayer and player in 2 functions instead?

I understand if not as it can be a bit redundant since is online isn't a hard condition to use after

[AyhamAl-Ali]

Was looking over this in the issue the suggested syntax was to do player(nameOrUUID, onlineOnly) is it still planned to make it support online only or was it just weird to see it used? and if not should we do offlinePlayer and player in 2 functions instead?

I understand if not as it can be a bit redundant since is online isn't a hard condition to use after

The main idea behind adding isOnline param was to avoid erroring when skript asks for player and finds offlineplayer however, this wasn't correct as Skript has offlineplayer -> player converter so it works well

This was the test I made first. IMO currently it's good how it is but if you have some use cases feel free to share them here

[Fusezion]

This was the test I made first. IMO currently it's good how it is but if you have some use cases feel free to share them here

Nope just wanted to make sure as I didn't see it mentioned, reasoning makes perfect sense to me.

[Pikachu920]

what do you think about using two functions (player and offlineplayer). that way, you don't have to remember what the boolean parameter means (plus it's more clear without looking at the docs).

[Fusezion]

support online only or was it just weird to see it used? and if not should we do offlinePlayer and player in 2 functions instead?

what do you think about using two functions (player and offlineplayer). that way, you don't have to remember what the boolean parameter means (plus it's more clear without looking at the docs).

was something I mentioned here as well, but it falls under the same thing as it's as simple as doing {_player} is online it just doesn't flow as well. Player as a standalone tells me hey this function returns a player object

[sovdeeth]

personally i'd like player(nameOrUUID, allowOffline), I think defaulting to online only is safer.
Having two functions would also follow the rule of only doing offline lookups if you tell it to, but i think would be a bit more cumbersome. You make a good point about remembering the argument, though, pikachu.

[AyhamAl-Ali]

what do you think about using two functions (player and offlineplayer). that way, you don't have to remember what the boolean parameter means (plus it's more clear without looking at the docs).

This falls under the same subject Fuze mentioned, read this reply and let me know what you think

[sovdeeth]

Optional addition could be a boolean flag to use getExactPlayer instead of just getPlayer. I know there have been a few complaints that parsing "a" as player will match "Andre", if Andre 's online and a isn't.

[AyhamAl-Ali]

Optional addition could be a boolean flag to use getExactPlayer instead of just getPlayer. I know there have been a few complaints that parsing "a" as player will match "Andre", if Andre 's online and a isn't.

Not sure about this addition, is there any useful use case for it? I am afraid users will just never use it OR misuse it and complain about their code not working as expected

[sovdeeth]

Optional addition could be a boolean flag to use getExactPlayer instead of just getPlayer. I know there have been a few complaints that parsing "a" as player will match "Andre", if Andre 's online and a isn't.

Not sure about this addition, is there any useful use case for it? I am afraid users will just never use it OR misuse it and complain about their code not working as expected

Say you have a stored list of names (or a text input from chat, or a sign, or something) and you need the player objects of the online players. You can:
a) parse all as player, which is cheaper but risks mis-parsing some names as other players
b) parse all as offlineplayer, and check who's online, more expensive but more reliable.

Additionally, this issue can and does pop up when using arguments in commands, but that's not related to this PR.

It'd be a niche and pretty minor addition, but something i'd appreciate and have seen a few people grapple with in SkUnity help channels.

[sovdeeth]

Looks solid!