-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some issues with ExprParse #5878
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AyhamAl-Ali
added
the
bug
An issue that needs to be fixed. Alternatively, a PR fixing an issue.
label
Aug 4, 2023
Moderocky
approved these changes
Aug 13, 2023
Moderocky
force-pushed
the
master
branch
3 times, most recently
from
September 16, 2023 16:59
bd134d0
to
3f08853
Compare
TheLimeGlass
requested changes
Sep 19, 2023
sovdeeth
approved these changes
Sep 20, 2023
TheLimeGlass
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a couple issues with ExprParse:
broadcast "1, 2" parsed as "%ints%" # broadcasts [1, 2]
. Now, it flattens the array if you're not setting a list to the expression.Additionally, this PR introduces a new ParseContext used specifically for this expression, called
PARSE
.Target Minecraft Versions: any
Requirements: none
Related Issues: none