Make event parsing more reliable #5900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnderscoreTud
added
the
enhancement
TheLimeGlass
requested changes
Aug 10, 2023
sovdeeth
approved these changes
Aug 10, 2023
Moderocky
approved these changes
Aug 10, 2023
TheLimeGlass
added
the
breaking changes
bluelhf
approved these changes
Aug 11, 2023
AyhamAl-Ali
approved these changes
Aug 24, 2023
TheLimeGlass
previously requested changes
Aug 27, 2023
Moderocky
force-pushed
the
master
branch
3 times, most recently
from
bd134d0
to
3f08853
Compare
Co-authored-by: LimeGlass <[email protected]>
Moderocky
reviewed
Sep 22, 2023
Pikachu920
approved these changes
Nov 11, 2023
sovdeeth
approved these changes
Nov 12, 2023
Fusezion
approved these changes
Nov 12, 2023
sovdeeth
added
2.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes event parsing more reliable by using a similar parsing strategy to if statements, by separating data related to the event and the actual syntax of the event so we could add data to the event pattern more easily in the future. The new event syntax will be
[on] <.+> [with priority (:(lowest|low|normal|high|highest|monitor))]where<.+>is the actual syntax of the event inputted by the user (without any modifications)Target Minecraft Versions: any
Requirements: none
Related Issues: none