Clean up vector classes and fix a few bugs. #5952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moderocky
approved these changes
Aug 30, 2023
src/main/java/ch/njol/skript/effects/EffVectorRotateAroundAnother.java
Outdated
Show resolved
Hide resolved
TheLimeGlass
added
the
enhancement
AyhamAl-Ali
approved these changes
Aug 31, 2023
src/main/java/ch/njol/skript/effects/EffVectorRotateAroundAnother.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/effects/EffVectorRotateAroundAnother.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprVectorAngleBetween.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprVectorCrossProduct.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprVectorDotProduct.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprVectorNormalize.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprVectorOfLocation.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprVectorSquaredLength.java
Outdated
Show resolved
Hide resolved
TheLimeGlass
approved these changes
Sep 16, 2023
sovdeeth
added
the
patch-ready
Moderocky
force-pushed
the
master
branch
3 times, most recently
from
bd134d0
to
3f08853
Compare
TheLimeGlass
requested changes
Sep 25, 2023
Co-authored-by: Ayham Al Ali <[email protected]>
sovdeeth
force-pushed
the
RotateVectorToStringFix
branch
from
da81980
to
729b0ec
Compare
TheLimeGlass
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleans up most vector files, removing author tags, replacing e with event, and some other misc improvements
Fixes a AIOOB with rotate around XYZ's toString, an issue where removing from vector length always sets to 0, 0, 0, and allows the setting of xyz components of multiple vectors at a time.
Target Minecraft Versions:
Requirements:
Related Issues: