-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orientation Change Support for Move Event #5961
Orientation Change Support for Move Event #5961
Conversation
LGTM |
Event rotate is misleading, it's on any movement. |
Rotate does not get called when the player rotates while moving, which it should be called for. |
I’ll sort out the issues when available. |
You could do:
Maybe not the cleanest, but the simplest change for users imo |
I guess that’s the best option to prevent a breaking change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work!
bd134d0
to
3f08853
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good
Description
This PR adds support for orientation related to Skript’s current move event!
Example syntaxes:
Target Minecraft Versions: any
Requirements: 1.16 (non-player living entities)
Related Issues: -