Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "is connected" pattern. #6105

Merged
merged 9 commits into from
Apr 15, 2024

Conversation

Moderocky
Copy link
Member

Description

Adds support for player is connected to the isOnline condition, as requested in #6100.

This also cleans up the old version to use parse tags over split pipe parse mark.


Target Minecraft Versions: any
Requirements: none
Related Issues: #6100

Copy link
Contributor

@Fusezion Fusezion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nit picks, overall everything seems fine.

Copy link
Contributor

@Fusezion Fusezion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

Copy link
Member

@AyhamAl-Ali AyhamAl-Ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR!

@AyhamAl-Ali AyhamAl-Ali added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Oct 6, 2023
@Moderocky Moderocky added the hacktoberfest-accepted Marks a PR as accepted for Hacktoberfest label Oct 14, 2023
@sovdeeth sovdeeth added the 2.9 Targeting a 2.9.X version release label Jan 1, 2024
Copy link
Member

@AyhamAl-Ali AyhamAl-Ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Moderocky Moderocky added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Apr 15, 2024
@Moderocky Moderocky merged commit 9bba481 into SkriptLang:dev/feature Apr 15, 2024
4 checks passed
@Moderocky Moderocky deleted the cond-is-connected branch April 15, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.9 Targeting a 2.9.X version release enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. hacktoberfest-accepted Marks a PR as accepted for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants