Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Patch) Fix NPE issue with drops in 1.20.2 #6239

Merged
merged 1 commit into from
Dec 21, 2023
Merged

(Patch) Fix NPE issue with drops in 1.20.2 #6239

merged 1 commit into from
Dec 21, 2023

Conversation

APickledWalrus
Copy link
Member

Description

This PR fixes the drops NPE for the patch branch to resolve test failures.

Target Minecraft Versions: any
Requirements: none
Related Issues: none

@APickledWalrus APickledWalrus added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Dec 18, 2023
@Fusezion
Copy link
Contributor

Should it be patch? next release is gonna be feature so unless we're planning to merge patch into master and master into feature again, seems like a pointless step

@APickledWalrus
Copy link
Member Author

Should it be patch? next release is gonna be feature so unless we're planning to merge patch into master and master into feature again, seems like a pointless step

This fix is already present in feature :) This is so that PRs already targeting patch can pass tests. Some PRs are still targeting patch, and if any are merged, patch will likely merged into feature again.

@Fusezion
Copy link
Contributor

Fusezion commented Dec 18, 2023 •
edited
Loading

This fix is already present in feature :) This is so that PRs already targeting patch can pass tests. Some PRs are still targeting patch, and if any are merged, patch will likely merged into feature again.

Never realized a fix was merged into feature, I'll need to update mine again then

@Pikachu920 Pikachu920 merged commit 2daaa6f into dev/patch Dec 21, 2023
5 checks passed
@Pikachu920 Pikachu920 deleted the fix/drops-npe branch December 21, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@Moderocky Moderocky Moderocky approved these changes

Assignees
No one assigned
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@APickledWalrus @Fusezion @sovdeeth @Moderocky @Pikachu920