-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more flexible static parse method #6306
Conversation
*/ | ||
@Nullable | ||
public static ParseResult parse(String text, SkriptPattern pattern, int parseFlags, ParseContext parseContext) { | ||
return parse(text, pattern.toString(), parseFlags, parseContext); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the idea here is to add a SkriptPattern overload now so that if it becomes possible to parse the text more performantly with the SkriptPattern, we can change the implementation to do so! that way addon developers can start using this now with the potential of future improvements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay stability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
Description
Some addons (including skript-reflect) are using the private
parse_i
method reflectively. This PR adds a proper way to do the same thing.Target Minecraft Versions: any
Requirements: none
Related Issues: none