Add a changer expression utility class #6340
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
reviewed
Jan 20, 2024
src/main/java/ch/njol/skript/expressions/base/ChangeExpression.java
Outdated
Show resolved
Hide resolved
sovdeeth
added
the
enhancement
…Lang/Skript into feature/change-expression
sovdeeth
requested changes
Sep 13, 2024
| @Override | ||
| protected void execute(Event e) { | ||
| Object[] delta = changer == null ? null : changer.getArray(e); | ||
| @SuppressWarnings("unchecked") |
There was a problem hiding this comment.
don't suppress warnings on a method, suppress them per statement.
|
|
||
| @Override | ||
| @Nullable | ||
| @SuppressWarnings({ "serial", "unchecked" }) |
Comment on lines
+60
to
+62
| @Nullable | ||
| @SuppressWarnings({ "serial", "unchecked" }) | ||
| public Class<?>[] acceptChange(ChangeMode mode) { |
There was a problem hiding this comment.
Suggested change
| @Nullable | |
| @SuppressWarnings({ "serial", "unchecked" }) | |
| public Class<?>[] acceptChange(ChangeMode mode) { | |
| public Class<?> @Nullable [] acceptChange(ChangeMode mode) { |
Comment on lines
+54
to
+55
| @Nullable | ||
| public ChangeMode[] getChangeModes() { |
There was a problem hiding this comment.
Suggested change
| @Nullable | |
| public ChangeMode[] getChangeModes() { | |
| public ChangeMode @Nullable [] getChangeModes() { |
| * @param values The values to set the expression with. | ||
| * @param mode The ChangeMode that is being used on this expression. | ||
| */ | ||
| public abstract void changing(Event event, @Nullable C[] values, ChangeMode mode); |
There was a problem hiding this comment.
Suggested change
| public abstract void changing(Event event, @Nullable C[] values, ChangeMode mode); | |
| public abstract void changing(Event event, C @Nullable [] values, ChangeMode mode); |
Comment on lines
+70
to
+72
| public final void change(Event event, @Nullable Object[] delta, ChangeMode mode) { | ||
| changing(event, (@Nullable C[]) delta, mode); | ||
| } |
There was a problem hiding this comment.
Suggested change
| public final void change(Event event, @Nullable Object[] delta, ChangeMode mode) { | |
| changing(event, (@Nullable C[]) delta, mode); | |
| } | |
| public final void change(Event event, Object @Nullable [] delta, ChangeMode mode) { | |
| changing(event, (C @Nullable []) delta, mode); | |
| } |
| } | ||
|
|
||
| @Override | ||
| @SuppressWarnings("unchecked") |
Comment on lines
+1
to
+18
| /** | ||
| * This file is part of Skript. | ||
| * | ||
| * Skript is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU General Public License as published by | ||
| * the Free Software Foundation, either version 3 of the License, or | ||
| * (at your option) any later version. | ||
| * | ||
| * Skript is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU General Public License | ||
| * along with Skript. If not, see <http://www.gnu.org/licenses/>. | ||
| * | ||
| * Copyright Peter Güttinger, SkriptLang team and contributors | ||
| */ |
There was a problem hiding this comment.
Suggested change
| /** | |
| * This file is part of Skript. | |
| * | |
| * Skript is free software: you can redistribute it and/or modify | |
| * it under the terms of the GNU General Public License as published by | |
| * the Free Software Foundation, either version 3 of the License, or | |
| * (at your option) any later version. | |
| * | |
| * Skript is distributed in the hope that it will be useful, | |
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | |
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | |
| * GNU General Public License for more details. | |
| * | |
| * You should have received a copy of the GNU General Public License | |
| * along with Skript. If not, see <http://www.gnu.org/licenses/>. | |
| * | |
| * Copyright Peter Güttinger, SkriptLang team and contributors | |
| */ |
| package ch.njol.skript.expressions.base; | ||
|
|
||
| import org.bukkit.event.Event; | ||
| import org.eclipse.jdt.annotation.Nullable; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a changer expression utility class
Target Minecraft Versions: any
Requirements: none
Related Issues: none