-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create SectionExitHandler interface #6349
Create SectionExitHandler interface #6349
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a nice change to me!
Oh, one thing, please change the star import back to the individual imports.
I'm not sure about the name. What do you think about something like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change
Thanks for this! |
Description
SectionExitHandler
, having one methodexit(Event)
.LoopSection
to implement this.This PR enables addons to add sections which don't need to hold loop counters doing something when exited.
Target Minecraft Versions: any
Requirements: none
Related Issues: none