Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Allow armour in armor change event #6357

Merged
merged 2 commits into from
Jan 29, 2024
Merged

🚀 Allow armour in armor change event #6357

merged 2 commits into from
Jan 29, 2024

Conversation

AyhamAl-Ali
Copy link
Member

Description

Adds armour option to armor change event and adds that option to search keyworkds

Target Minecraft Versions: any
Requirements: none
Related Issues: none

@AyhamAl-Ali AyhamAl-Ali added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Jan 21, 2024
sovdeeth
sovdeeth approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is something we can do in a patch version; i don't really see the need to wait for July for such a change.

@AyhamAl-Ali AyhamAl-Ali changed the base branch from dev/feature to dev/patch January 29, 2024 19:55
@AyhamAl-Ali AyhamAl-Ali merged commit 253b026 into SkriptLang:dev/patch Jan 29, 2024
4 checks passed
@AyhamAl-Ali AyhamAl-Ali added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@TheLimeGlass TheLimeGlass TheLimeGlass approved these changes

@APickledWalrus APickledWalrus APickledWalrus approved these changes

Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AyhamAl-Ali @sovdeeth @TheLimeGlass @APickledWalrus