Bell API #6456
Merged
Bell API #6456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLimeGlass
approved these changes
Feb 23, 2024
src/test/java/org/skriptlang/skript/test/tests/syntaxes/events/BellEventsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/skriptlang/skript/test/tests/syntaxes/events/BellEventsTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: LimeGlass <[email protected]>
Co-authored-by: LimeGlass <[email protected]>
Co-authored-by: LimeGlass <[email protected]>
APickledWalrus
requested changes
Mar 9, 2024
src/main/java/ch/njol/skript/expressions/ExprResonatingTime.java
Outdated
Show resolved
Hide resolved
src/test/java/org/skriptlang/skript/test/tests/syntaxes/events/BellEventsTest.java
Outdated
Show resolved
Hide resolved
Moderocky
approved these changes
Mar 27, 2024
|
Conflicts needs to be resolved |
sovdeeth
approved these changes
Mar 30, 2024
sovdeeth
added
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request implements events, conditions, expressions, and effects related to bells.
Target Minecraft Versions: any
Requirements: Paper (for ringing events between 1.16.5 and 1.19.4)
Related Issues: none