Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Entity Teleport event. #6530

Merged

Conversation

Asleeepp
Copy link
Contributor

@Asleeepp Asleeepp commented Apr 3, 2024

Description

Added the Entity Teleport event, with a couple event-values. If you'd like me to add more, just say. :)
Original Issue: #5825


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@AyhamAl-Ali AyhamAl-Ali added the feature Pull request adding a new feature. label Apr 3, 2024
Copy link
Member

@AyhamAl-Ali AyhamAl-Ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work ⚡

src/main/java/ch/njol/skript/events/EvtEntityTeleport.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtEntityTeleport.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtEntityTeleport.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtEntityTeleport.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtEntityTeleport.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtEntityTeleport.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtEntityTeleport.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtEntityTeleport.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtEntityTeleport.java Outdated Show resolved Hide resolved
…moved Player Teleport from SimpleEvents into EvtTeleport
@Asleeepp
Copy link
Contributor Author

Asleeepp commented Apr 3, 2024

Ive added the Player Teleport Event.

Copy link
Member

@Moderocky Moderocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, just a few little notes.

src/main/java/ch/njol/skript/events/EvtTeleport.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtTeleport.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtTeleport.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtTeleport.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtTeleport.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtTeleport.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtTeleport.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtTeleport.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtTeleport.java Outdated Show resolved Hide resolved
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oop this too

src/main/java/ch/njol/skript/events/EvtTeleport.java Outdated Show resolved Hide resolved
@Asleeepp Asleeepp requested a review from sovdeeth April 19, 2024 02:12
@Asleeepp Asleeepp requested a review from sovdeeth April 19, 2024 15:21
@sovdeeth sovdeeth changed the base branch from master to dev/feature April 19, 2024 21:14
@sovdeeth sovdeeth added feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. 2.9 Targeting a 2.9.X version release labels Jun 29, 2024
@APickledWalrus APickledWalrus added the breaking changes Pull or feature requests that contain breaking changes (API, syntax, etc.) label Jul 1, 2024
@APickledWalrus APickledWalrus merged commit 7111887 into SkriptLang:dev/feature Jul 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.9 Targeting a 2.9.X version release breaking changes Pull or feature requests that contain breaking changes (API, syntax, etc.) feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants