Add ClassInfoReference system #6531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AyhamAl-Ali
added
the
enhancement
sovdeeth
approved these changes
Apr 3, 2024
sovdeeth
added
the
feature-ready
APickledWalrus
requested changes
Apr 3, 2024
AyhamAl-Ali
approved these changes
Apr 4, 2024
Pikachu920
requested review from
APickledWalrus
and removed request for
APickledWalrus
APickledWalrus
approved these changes
Apr 11, 2024
Co-authored-by: Patrick Miller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a ClassInfoReference API which provides an easy wrapper around handling the plurality of ClassInfo literals. An example of the existing way can be seen in the edits to
ExprValueWithin, although that expression doesn't take full advantage of the API since it's limited to literal classinfos.Target Minecraft Versions: any
Requirements: none
Related Issues: none