Pattern Keyword Enhancements #6550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APickledWalrus
added
enhancement
Moderocky
approved these changes
Apr 11, 2024
| @@ -68,24 +67,6 @@ public String toString() { | |||
| return first.toFullString(); | |||
| } | |||
|
|
|||
| public static String[] getKeywords(PatternElement first) { | |||
There was a problem hiding this comment.
We could keep this method with a deprecation notice just in case somebody is still using it.
sovdeeth
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements some enhancements to the keyword system to further reduce parse times (notably on servers with a larger number of scripts).
Essentially, support is added for starting and ending keywords (keywords that appear at the start/end of a pattern). This allows usage of
String#startsWith/String#endsWithoverString#contains.Support is also added for keywords from choice elements. That is,
(one|two)may now be represented by a keyword that searches for eitheroneortwoin the string. If neither are present, it fails. This supports the starting/ending behavior described above.As a breaking change,
SkriptPattern#getKeywordswas removed. I do not believe this method is used by any addons (it is only used in one place in Skript).Target Minecraft Versions: any
Requirements: none
Related Issues: none