-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple Structures #6551
Simple Structures #6551
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having actually used this myself I can say it works 🤣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work Pickle! LGTM 🚀
src/main/java/org/skriptlang/skript/lang/structure/Structure.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/lang/structure/Structure.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good!
Description
This PR adds support for registering Structure that do not have sections. That is, they are based on SimpleNodes rather than SectionNodes. They simply look like:
A Structure may be registered this way using
Skript#registerSimpleStructure
.An API change was required that makes
EntryContainer
nullable in Structure's init. This will not break any existing code as for non-simple Structures, it is guaranteed that EntryContainer is NotNull.Structure#getEntryContainer
has also been deprecated. This method's existence was previously justified for internal reasons, but those reasons no longer exist (design has improved), so neither will this method in the future. Developers are encouraged to save a reference to the entry container during initialization if they need it during the loading period.Target Minecraft Versions: any
Requirements: none
Related Issues: