Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix weird item mutation bug with EffHealth #6586
Fix weird item mutation bug with EffHealth #6586
Changes from 9 commits
4db1f91
58c1ebf
e3492e9
b7b048d
379ead2
0808a6e
c76a230
b3d0435
edc3a92
dbc7753
a5f1578
9aed771
ca10a60
31756f2
f83123a
2fae70b
57b6553
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to 1.20.5 changes this is now technically bugable due to custom durability component. Forgot all about that.
In addition
Damageable
ItemMeta is available on all items as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think this is worth delaying this addition, or should we get it in 2.6.5 and worry about the 1.20.5 changes later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking over it, is appears spigot has just thrown the the
#setMaxDamage
method intoDamageable
, I can quickly see how a test build of this interacts but as paper still has no stable release only betas I likely cannot push it for awhile longer.