Adds support for modifying the tick rate #6592

Asleeepp · 2024-04-19T17:31:59Z

Description

This PR aims to add support for the tick rate to be changed, modified, etc, etc
Currently unfinished.
Plans to add a lot more to this.

Target Minecraft Versions: 1.20.3+
Requirements: none
Related Issues: none

…ion-modify-tick

sovdeeth

This also needs tests for the parts that can be tested. (probably can't test stepping, maybe with junit)

src/main/java/ch/njol/skript/conditions/CondEntityFrozen.java

src/main/java/ch/njol/skript/expressions/ExprTick.java

src/main/java/ch/njol/skript/conditions/CondEntityFrozen.java

src/main/java/ch/njol/skript/conditions/CondIsTickFrozen.java

src/main/java/ch/njol/skript/conditions/CondServerTickState.java

src/main/java/ch/njol/skript/effects/EffFreezeServer.java

src/main/java/ch/njol/skript/expressions/ExprFrozenTicksToRun.java

src/main/java/ch/njol/skript/expressions/ExprTick.java

src/main/java/ch/njol/skript/expressions/ExprFrozenTicksToRun.java

src/main/java/ch/njol/skript/expressions/ExprTick.java

src/main/java/ch/njol/skript/conditions/CondServerTickState.java

sovdeeth

just minor stuff
will test tomorrow

src/main/java/ch/njol/skript/effects/EffSprintServer.java

src/main/java/ch/njol/skript/conditions/CondServerTickState.java

src/main/java/ch/njol/skript/bukkitutil/ServerUtils.java

src/main/java/ch/njol/skript/conditions/CondIsTickFrozen.java

src/main/java/ch/njol/skript/expressions/ExprTick.java

src/main/java/ch/njol/skript/conditions/CondServerTickState.java

APickledWalrus · 2024-06-27T19:08:33Z

src/main/java/ch/njol/skript/conditions/CondServerTickState.java

+
+	@Override
+	public boolean init(Expression<?>[] exprs, int matchedPattern, Kleenean isDelayed, ParseResult parseResult) {
+		if (!parseResult.tags.isEmpty()) {


this should always be true (so it can be removed)

src/main/java/ch/njol/skript/effects/EffSprintServer.java

src/main/java/ch/njol/skript/conditions/CondServerTickState.java

src/main/java/ch/njol/skript/effects/EffStepServer.java

src/main/java/ch/njol/skript/expressions/ExprFrozenTicksToRun.java

src/main/java/ch/njol/skript/expressions/ExprServerTickRate.java

src/main/java/ch/njol/skript/effects/EffStepServer.java

…ion-modify-tick

src/main/java/ch/njol/skript/expressions/ExprServerTickRate.java

src/main/java/ch/njol/skript/effects/EffStepServer.java

src/main/java/ch/njol/skript/effects/EffSprintServer.java

src/main/java/ch/njol/skript/conditions/CondServerTickState.java

src/main/java/ch/njol/skript/effects/EffFreezeServer.java

src/main/java/ch/njol/skript/conditions/CondServerTickState.java

src/main/java/ch/njol/skript/effects/EffStepServer.java

src/main/java/ch/njol/skript/expressions/ExprFrozenTicksToRun.java

UnderscoreTud · 2024-08-19T19:36:32Z

src/main/java/ch/njol/skript/expressions/ExprServerTickRate.java

+})
+@Since("INSERT VERSION")
+@RequiredPlugins("Minecraft 1.20.4+")
+public class ExprServerTickRate extends SimpleExpression<Float> {


Is there any connection between this and tps? I can see them getting mixed up.

The existing TPS expression gets the TPS over a period of time (1, 5, 15 minutes)

This one gets the current tick rate, which is most likely more precise then the existing expression, its also more specific to tick rate management, as opposed to average TPS over intervals.

though maybe this should be an option of that expression instead of something entirely new? Would love to hear other peoples thoughts

Though, if it were to get added to that expression, I feel it would be tricky to come up with good syntax for it as [the] tps already exists in that expression, and returns all of the tps over the intervals.

putting this into that expression would output some dodgy syntax i feel like, I personally think it'd be best to keep them separate, but like I said before, would love to hear some other peoples thoughts

No this doesn't get a more precise tps
It gets/sets the goal tps, which by default is 20. Your server can be having 10 tps but be targetting 20 tps, therefore lagging. It can have 5 tps and target 5 tps, therefor not lagging. TPS would return 10 and 5 respectively, but this expression would return 20 and 5.

No this doesn't get a more precise tps It gets/sets the goal tps, which by default is 20. Your server can be having 10 tps but be targetting 20 tps, therefore lagging. It can have 5 tps and target 5 tps, therefor not lagging. TPS would return 10 and 5 respectively, but this expression would return 20 and 5.

whoops 😅, then yeah, this should stay its own expression

TheAbsolutionism · 2024-09-10T06:42:19Z

#6314

Asleeepp added 2 commits April 19, 2024 14:25

start

937feca

start

69dab63

Asleeepp marked this pull request as draft April 19, 2024 17:32

Asleeepp added 2 commits April 19, 2024 15:30

fixes build failure, hopefully

2e2b1ca

2nd time lucky

0baa016

AyhamAl-Ali added the feature Pull request adding a new feature. label Apr 19, 2024

sovdeeth changed the base branch from master to dev/feature April 19, 2024 21:14

Asleeepp and others added 12 commits April 19, 2024 18:26

freeze, sprint and step

b097852

Merge branch 'dev/feature' into addition-modify-tick

dc6d158

Merge remote-tracking branch 'origin/addition-modify-tick' into addit…

8939d76

…ion-modify-tick

e

d9d887e

e

a79700e

changed ExprTick to simpleexpression

a536e61

Fixes and additions

dc282d8

Fix

cc51f01

license moment

3d07f89

Additions + Docs

2c5a132

sigh

7a037d7

Leaving BukkitClasses.java as it was

f5d1f0e

Asleeepp marked this pull request as ready for review April 21, 2024 12:35

sovdeeth requested changes Apr 21, 2024

View reviewed changes

Moderocky requested changes Apr 21, 2024

View reviewed changes

src/main/java/ch/njol/skript/conditions/CondEntityFrozen.java Outdated Show resolved Hide resolved

src/main/java/ch/njol/skript/conditions/CondEntityFrozen.java Outdated Show resolved Hide resolved

jesus christ

22826fe

Asleeepp requested a review from sovdeeth April 22, 2024 19:02

sovdeeth requested changes Apr 23, 2024

View reviewed changes

Suggested changes.

5a80a00

Asleeepp requested review from sovdeeth and Moderocky April 26, 2024 18:49

sovdeeth requested changes May 1, 2024

View reviewed changes

src/main/java/ch/njol/skript/conditions/CondServerTickState.java Outdated Show resolved Hide resolved

Have i done this right? (probably not)

b890d94

sovdeeth requested changes May 7, 2024

View reviewed changes

src/main/java/ch/njol/skript/effects/EffSprintServer.java Outdated Show resolved Hide resolved

src/main/java/ch/njol/skript/conditions/CondServerTickState.java Outdated Show resolved Hide resolved

Asleeepp and others added 2 commits May 7, 2024 19:51

suggested changes x95954865

7bbf510

Merge branch 'dev/feature' into addition-modify-tick

3bd296f

UnderscoreTud requested changes Jun 1, 2024

View reviewed changes

Asleeepp added 4 commits June 21, 2024 15:16

Merge branch 'dev/feature' into addition-modify-tick

3cec433

Changes + tests

8fdfed6

WORKING tests

2308449

ACTUAL working tests

53dabc9

Asleeepp requested review from sovdeeth, Moderocky and UnderscoreTud June 21, 2024 18:46

Number -> float + Server tick rate test

8d35f8e

APickledWalrus requested changes Jun 27, 2024

View reviewed changes

Asleeepp added 3 commits June 27, 2024 18:08

Suggested

9f205f4

Merge branch 'dev/feature' into addition-modify-tick

3b0272e

Merge remote-tracking branch 'origin/addition-modify-tick' into addit…

8295cb9

…ion-modify-tick

sovdeeth approved these changes Jun 28, 2024

View reviewed changes

Slight syntax change

936f566

Asleeepp requested a review from APickledWalrus June 28, 2024 19:52

sovdeeth added the 2.9 Targeting a 2.9.X version release label Jun 29, 2024

APickledWalrus requested changes Jul 1, 2024

View reviewed changes

stuff

9b6124e

APickledWalrus removed the 2.9 Targeting a 2.9.X version release label Jul 2, 2024

Moderocky approved these changes Aug 15, 2024

View reviewed changes

UnderscoreTud requested changes Aug 19, 2024

View reviewed changes

Asleeepp added 2 commits September 4, 2024 20:46

Merge branch 'dev/feature' into addition-modify-tick

936ebb9

suggested changes

44dd920

Asleeepp requested review from APickledWalrus and UnderscoreTud September 4, 2024 23:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds support for modifying the tick rate #6592

Adds support for modifying the tick rate #6592

Asleeepp commented Apr 19, 2024

sovdeeth left a comment

sovdeeth left a comment

APickledWalrus Jun 27, 2024

UnderscoreTud Aug 19, 2024

Asleeepp Sep 4, 2024 •

edited

Loading

Asleeepp Sep 4, 2024

sovdeeth Sep 5, 2024

Asleeepp Sep 5, 2024 •

edited

Loading

TheAbsolutionism commented Sep 10, 2024

Adds support for modifying the tick rate #6592

Are you sure you want to change the base?

Adds support for modifying the tick rate #6592

Conversation

Asleeepp commented Apr 19, 2024

Description

sovdeeth left a comment

Choose a reason for hiding this comment

sovdeeth left a comment

Choose a reason for hiding this comment

APickledWalrus Jun 27, 2024

Choose a reason for hiding this comment

UnderscoreTud Aug 19, 2024

Choose a reason for hiding this comment

Asleeepp Sep 4, 2024 • edited Loading

Choose a reason for hiding this comment

Asleeepp Sep 4, 2024

Choose a reason for hiding this comment

sovdeeth Sep 5, 2024

Choose a reason for hiding this comment

Asleeepp Sep 5, 2024 • edited Loading

Choose a reason for hiding this comment

TheAbsolutionism commented Sep 10, 2024

Asleeepp Sep 4, 2024 •

edited

Loading

Asleeepp Sep 5, 2024 •

edited

Loading