Add dynamic usage messages for commands #6627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
enhancement
Moderocky
requested changes
Apr 30, 2024
Moderocky
approved these changes
May 1, 2024
APickledWalrus
approved these changes
May 5, 2024
sovdeeth
added
the
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the usage field in StructCommand to use VariableString, allowing the input of expressions.
The Bukkit command registration wants a static usage message, though, so a default usage message is also supplied (if the varString is simple, it's the varString, otherwise the default usage message for the command)
I'd prefer this to have more features, like a whole section for usage validation based on what arguments were misused, but that's for the command rework, not now.
Target Minecraft Versions: any
Requirements: none
Related Issues: none