-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.20.5 Support (part 2) #6630
Merged
Merged
1.20.5 Support (part 2) #6630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now targets to the 1.20.5 support branch
This is useful for items that have NBT that is not represented by an ItemMeta implementation (e.g. block entity data)
Also updates Java from 17 to 21
Removed ones do not currently work on new versions...
We cannot use EasyMock on Java 21 as we must stay on an older version (see #6204 (comment)) Java 21 will be supported for regular testing. A 1.20.4 environment remains for Java 17
sovdeeth
approved these changes
May 1, 2024
Moderocky
approved these changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#6617 was merged a little too early.
SkriptLang/skript-aliases#112 must be merged first, and then this PR will require updates.aliases have been updatedTarget Minecraft Versions: any
Requirements: none
Related Issues: none