EffHealth - fix max damage on custom items #6646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
approved these changes
May 5, 2024
sovdeeth
added
bug
Moderocky
approved these changes
May 6, 2024
Moderocky
added
the
patch-ready
sovdeeth
added a commit
to sovdeeth/Skript
that referenced
this pull request
May 30, 2024
Co-authored-by: sovdee <[email protected]>
sovdeeth
added a commit
to sovdeeth/Skript
that referenced
this pull request
May 30, 2024
Co-authored-by: sovdee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix an issue with max damage on custom damageable items.
EX: In MC 1.20.5+ I can create an apple that is able to take damage.
This checks the max damage from ItemMeta (if available) otherwise falls back to max durability from Material
(ive also taken into account Fuse's PR fixing the other bug in the same class since the PR isn't merged.)
Target Minecraft Versions: 1.20.5+
Requirements: none
Related Issues: none