String literal. #6718
Merged
String literal. #6718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moderocky
added
the
enhancement
Moderocky
requested review from
APickledWalrus,
sovdeeth and
UnderscoreTud
and removed request for
APickledWalrus and
sovdeeth
Draft
Moderocky
commented
May 29, 2024
Comment on lines
+612
to
+613
| if (!aClass.getC().isAssignableFrom(String.class)) | ||
| continue; |
There was a problem hiding this comment.
Literals can only be converted to other literals, so we don't really want to return a literal unless the input actually wants a string (otherwise a lot of places might break because they can't be converted)
APickledWalrus
approved these changes
May 29, 2024
|
|
||
| import java.util.Optional; | ||
|
|
||
| public class LiteralString extends VariableString implements Literal<String> { |
There was a problem hiding this comment.
Might be worth adding some javadoc for the class itself
Co-authored-by: Patrick Miller <[email protected]>
Moderocky
added
feature-ready
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
LiteralString.During string parsing, if the string is 'simple' (has no interpolation inputs or weird parsy bits and bobs) then rather than returning a 'simple'
VariableString, it will return aLiteralString. This is aLiteral<String>.Incidentally, this is also a
VariableString, so nothing existing will break.You can now specify
%*string%to accept (literal) strings obtainable during init, and use strings in places where only literals are allowed.Obviously, strings with expressions inside (like
"hello %player%") aren't literal and so won't be matched.Target Minecraft Versions: any
Requirements: none
Related Issues: none