Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PotionData NPE #6757

Conversation

APickledWalrus
Copy link
Member

Description

This PR fixes an NPE that can occur on when attempting to obtain the potion effects of a potion without a base type.

I have removed the reflection usage for a method that was originally removed when I made the 1.20.5+ support PR. The method seems to have been added back in. However, I am forcing the usage of the recommended method when it is available.


Target Minecraft Versions: any
Requirements: none
Related Issues:

@APickledWalrus APickledWalrus added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Jun 3, 2024
@APickledWalrus APickledWalrus merged commit b9a7ab8 into SkriptLang:dev/patch Jun 6, 2024
5 checks passed
@APickledWalrus APickledWalrus deleted the patch/missing-potion-data-npe branch June 6, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants