Fix Command Syncing CME #6763
Merged
Fix Command Syncing CME #6763
+17
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APickledWalrus
added
the
bug
sovdeeth
approved these changes
Jun 3, 2024
I was wondering about that too but wasn't sure. I'm not sure if it makes a major difference. |
|
I suppose it would be better to make the minimum amount of behavioral change possible, but also it'd be nice to have the same behavior on all versions. I'm not too fussed either way. |
Moderocky
approved these changes
Jun 4, 2024
sovdeeth
approved these changes
Jun 6, 2024
sovdeeth
added
the
patch-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix the CME that occurs when syncing commands on Paper 1.20.5+ versions due to internal command changes. This issue only seems to occur when a command is unregistered, registered, and then synced in the same tick. Adding a single tick delay seems to remove the error. I would prefer a fix that doesn't force a delay, but I could not find any other solutions.
Target Minecraft Versions: any
Requirements: none
Related Issues: