Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registry - more registries #6806

Merged
merged 5 commits into from
Jul 1, 2024
Merged

Registry - more registries #6806

merged 5 commits into from
Jul 1, 2024

Conversation

ShaneBeee
Copy link
Contributor

@ShaneBeee ShaneBeee commented Jun 22, 2024 •
edited
Loading

Description

This PR aims to add more registries (CatType, Attributes)
I'll look into doing PotionEffectType at a later date.
Other than that, Skript doesn't use any other registry types.

NOTE:

  • attribute names in the lang file are enum names, so ive had to add another variation to match Minecraft namespaces
  • this also includes updated attributes for 1.21
  • I added a quick method to check for registry existence

Target Minecraft Versions: any
Requirements: none
Related Issues: none

Moderocky
Moderocky approved these changes Jun 22, 2024
View reviewed changes
Copy link
Member

@Moderocky Moderocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registries 2: The Registering

@sovdeeth sovdeeth added enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. 2.9 Targeting a 2.9.X version release labels Jun 28, 2024
@sovdeeth sovdeeth merged commit f6f41ca into SkriptLang:dev/feature Jul 1, 2024
5 checks passed
@ShaneBeee ShaneBeee deleted the feature/more-registries branch July 1, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@Moderocky Moderocky Moderocky approved these changes

@APickledWalrus APickledWalrus APickledWalrus approved these changes

Assignees
No one assigned
Labels
2.9 Targeting a 2.9.X version release enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ShaneBeee @sovdeeth @Moderocky @APickledWalrus