add allowLookups option to offlineplayer function #6831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
enhancement
Pikachu920
approved these changes
Jun 30, 2024
Moderocky
approved these changes
Jul 1, 2024
sovdeeth
added
the
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since offlineplayer lookups by name can block the server while they request the uuid from Mojang, they can be very dangerous to parse as. This adds a optional parameter to prevent lookups in the offlineplayer() function for Paper 1.16.5+
I would like opinions on the validity of the Notch test though, since it would fail if the user doesn't have an internet connection or the auth servers go down. Let me know if it should be removed.
Target Minecraft Versions: paper 1.16.5+
Requirements: none
Related Issues: none